New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecated getargspec #479

Merged
merged 7 commits into from Jun 24, 2016

Conversation

Projects
None yet
3 participants
@deckar01
Member

deckar01 commented Jun 23, 2016

Replaces #415 and #478.

  • Ignore bound arguments returned from inspect.getargspec() to match the behavior of inspect.signature().
  • Add a test demonstrating how using get_func_args() with inspect.getargspec() was broken when the serializer had a bound argument.

@deckar01 deckar01 referenced this pull request Jun 23, 2016

Closed

Deprecated getargspec #478

@deckar01 deckar01 force-pushed the deckar01:deprecated-getargspec branch from 57b5339 to 1736831 Jun 23, 2016

@deckar01

This comment has been minimized.

Member

deckar01 commented Jun 23, 2016

I went ahead and opened #480 to bring the pyinvoke fixes to 3.0 and rebased this branch so the tests would work.

@sloria

This comment has been minimized.

Member

sloria commented Jun 24, 2016

Thanks!

@sloria sloria merged commit fe4b744 into marshmallow-code:3.0 Jun 24, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@sloria sloria added this to the 3.0 milestone Jun 24, 2016

@sloria sloria modified the milestones: 3.0, 3.0a Feb 18, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment