Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix UUID fields not validating on serialize #532

merged 1 commit into from Sep 25, 2016


Copy link

commented Sep 20, 2016

UUIDs are currently only validated on deserialization/load. This validates them on serialize/dump as well. This is technically a breaking change, but the current behavior is probably undesirable in any case where it's being used.

@pauljz pauljz changed the title Fix UUID not validating on serialize Fix UUID fields not validating on serialize Sep 20, 2016

Copy link

left a comment

Although it's a strange thing to fail validation when you serialize data (meaning data that is originating from you does not hold invariants), but PR looks legit.

@sloria sloria merged commit 5e5f1ad into marshmallow-code:dev Sep 25, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
3 participants
You can’t perform that action at this time.