New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ordered schema support for inherited fields #592

Merged
merged 1 commit into from Mar 4, 2017

Conversation

Projects
None yet
2 participants
@frol
Contributor

frol commented Mar 4, 2017

@sloria I am sorry, I am completely lost here. I have a biggish project in which I use ordered schemas with Marshmallow-SQLAlchemy, and I have noticed that fields on some of the schemas end up being resorted on every restart... My debug lead me to this change, but I cannot create a test for it :(

@sloria

This comment has been minimized.

Member

sloria commented Mar 4, 2017

Hm, I would expect this test to fail without this change, but this change looks correct nonetheless. I'll backport this to the 2.x-line branch and release a hotfix.

@sloria sloria merged commit 35fdf58 into marshmallow-code:dev Mar 4, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment