New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes from_iso to from_iso_datetime #694

Merged
merged 2 commits into from Oct 29, 2017

Conversation

Projects
None yet
2 participants
@sklarsa
Contributor

sklarsa commented Oct 27, 2017

Since the iso regex used in utils.from_iso does not handle iso-formatted dates (%Y-%m-%d), I renamed this method to make its functionality clearer.

@sloria

This comment has been minimized.

Member

sloria commented Oct 28, 2017

I'm fine with the name change, but I think we should deprecate--rather than remove-- the old function.

def from_iso(...):
    warnings.warn('from_iso is deprecated. Use from_iso_datetime instead.', UserWarning)
    return from_iso_datetime(...)
@sloria

This comment has been minimized.

Member

sloria commented Oct 29, 2017

Thanks!

@sloria sloria merged commit ebcfcb9 into marshmallow-code:dev Oct 29, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment