New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow username without password in basic auth part of the url. #982

Merged
merged 2 commits into from Oct 10, 2018

Conversation

Projects
None yet
3 participants
@alefnula
Contributor

alefnula commented Oct 8, 2018

Some URLs, for example gitlab ssh URLs (ssh://git@gitlab.domain.com:2222/user/project.git) don't have a password in itself. This pull request allows validating URLs with only user in basic auth part of the url.

alefnula added some commits Oct 8, 2018

Allow username without password in basic auth part of the url.
Some URLs, for example gitlab ssh URLs (ssh://git@gitlab.domain.com:2222/user/project.git) don't have a password in itself. This pull request allows validating URLs with only user in basic auth part of the url.

@lafrech lafrech merged commit 4b996f3 into marshmallow-code:dev Oct 10, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@lafrech

This comment has been minimized.

Member

lafrech commented Oct 10, 2018

Thanks.

@lafrech

This comment has been minimized.

Member

lafrech commented Oct 10, 2018

I documented this as a feature in the CHANGELOG. Could be a bugfix. @sloria, feel free to edit.

@sloria

This comment has been minimized.

Member

sloria commented Oct 10, 2018

Yeah, this is a bugfix. I've backported in #983

sloria added a commit that referenced this pull request Oct 11, 2018

Merge pull request #983 from marshmallow-code/backport-982
Backport #982: Allow username without password in basic auth part of the url.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment