New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Pluck load with data_key #990

Merged
merged 1 commit into from Oct 13, 2018

Conversation

Projects
None yet
2 participants
@lafrech
Member

lafrech commented Oct 11, 2018

The data_key must be managed also when deserializing.

@deckar01 do you think you could check this is correct?

@lafrech lafrech added the bug label Oct 11, 2018

@lafrech lafrech added this to the 3.0 milestone Oct 11, 2018

@lafrech lafrech requested a review from deckar01 Oct 11, 2018

@sloria

sloria approved these changes Oct 13, 2018

Behavior looks correct.

Without this change, the added assertion fails with an uncaught error:

marshmallow.exceptions.ValidationError: {'collaborators': {0: {'name': ['Unknown field.']}, 1: {'name': ['Unknown field.']}}, 'user': {'name': ['Unknown field.']}}

This restores the dump/load symmetry. 👌

@sloria sloria merged commit 10543cf into dev Oct 13, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@sloria sloria deleted the fix_pluck_data_key_load branch Oct 13, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment