Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow_missing=False not working with nested args #39

Closed
ewang opened this issue May 7, 2015 · 1 comment

Comments

@ewang
Copy link

commented May 7, 2015

Nested args currently do not respect the allow_missing flag.

Example:
Argmap: {"nested": Arg({"a": Arg(str), "b": Arg(str)})}
JSON request body: {}
Should return {"nested": {"a": null, "b": null}}
Instead returns {}

I was looking at the current nested args parsing logic, it seems to bypass most of the logic of dealing w/ allow_missing in Parser#parse.

Perhaps nested args can be implemented simply by calling Parser#parse with the nested argmap. Any thoughts?

@sloria

This comment has been minimized.

Copy link
Member

commented Sep 27, 2015

This will be solved by using marshmallow's Nested field.

@sloria sloria closed this Sep 27, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.