Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Minor refactor in core.py #222
This simplifies the code a bit.
No test broken. However, any custom parser that overrides
Does that make it a breaking change? The docs read
I'm fine with this change. I think it's a breaking change, though, since we're removing a public method of a public class. We should try our best to follow semver as conservatively as is practical. We can make clear in the CHANGELOG that this change shouldn't affect most users.