Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor refactor in core.py #222

Merged
merged 4 commits into from May 4, 2018

Conversation

@lafrech
Copy link
Member

commented Apr 30, 2018

Closes #216.

This simplifies the code a bit.

No test broken. However, any custom parser that overrides Parser.parse (or AsyncParser.parse) and calls Parser.load requires a little adaptation.

Does that make it a breaking change? The docs read

To add your own parser, extend Parser and implement the parse_* method(s) you need to override.

Parser.parse and Parser.load are not exposed, so it can be argued that the API is not changed.

@sloria

This comment has been minimized.

Copy link
Member

commented May 4, 2018

I'm fine with this change. I think it's a breaking change, though, since we're removing a public method of a public class. We should try our best to follow semver as conservatively as is practical. We can make clear in the CHANGELOG that this change shouldn't affect most users.

@lafrech

This comment has been minimized.

Copy link
Member Author

commented May 4, 2018

I just updated the changelog.

@sloria

This comment has been minimized.

Copy link
Member

commented May 4, 2018

Thanks. The failing build is unrelated to this change, so this is good to merge.

@sloria sloria merged commit 31d7175 into marshmallow-code:dev May 4, 2018

1 check failed

continuous-integration/travis-ci/pr The Travis CI build failed
Details

@lafrech lafrech deleted the Nobatek:dev_core_rework branch Jul 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.