Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python 3.7 async and await are now reserved keywords. #240

Merged
merged 1 commit into from Jul 8, 2018

Conversation

@Reskov
Copy link

commented Jul 7, 2018

At python 3.7 import webargs async module will raise following syntax exception

from webargs.async import AsyncParser
  File "<input>", line 1
    from webargs.async import AsyncParser
                     ^
SyntaxError: invalid syntax

@sloria sloria added the bug label Jul 6, 2018

@sloria

This comment has been minimized.

Copy link
Member

commented Jul 6, 2018

Thanks for reporting @Reskov . Looks like we need to rename that module. We'll have this fixed sometime this weekend.

@sloria sloria assigned sloria and unassigned sloria Jul 6, 2018

@sloria

This comment has been minimized.

Copy link
Member

commented Jul 6, 2018

If you'd like to send a PR renaming webargs.async -> webargs.asyncparser, be my guest! If you don't have time, I can take care of it this weekend.

Sergey Kovalev
@sloria

This comment has been minimized.

Copy link
Member

commented Jul 8, 2018

Thanks @Reskov !

@sloria sloria merged commit 896ca00 into marshmallow-code:dev Jul 8, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.