Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Sanic support: parser, test app, tests #287

Closed
wants to merge 4 commits into from

Conversation

@dnikolayev
Copy link

commented Sep 17, 2018

We commonly use webargs + flask.
However, there was a requirement to build a project using Sanic.
To have the same style support with common practice Sanic support was added.
Please review.
@sloria, to enable Sanic support webtest-sanic package was released. The code of webtest-sanic is fully based on your library webtest-aiohttp and all creds saved.

dnikolayev added some commits Sep 17, 2018

@sloria

This comment has been minimized.

Copy link
Member

commented Sep 17, 2018

Hi @dnikolayev . Thanks for your work on this!

In order to keep this library small and easy to maintain, we've stopped adding support for new frameworks, so I'm going to close this.

For now, I recommend adding webargs-sanic to https://github.com/sloria/webargs/wiki/Ecosystem . I'll forward people to that library when asked about sanic support.

Also, would it help if CommonTestCase were exposed in the PyPI package so you could import it in webargs-sanic?

@sloria sloria closed this Sep 17, 2018

@dnikolayev

This comment has been minimized.

Copy link
Author

commented Sep 17, 2018

Ok, I see. I already started to update docs and check contributing policies to pass everything, LOL

As for the "CommonTestCase" - Well, I guess so.
Could you please release it? Will it take much time?

@sloria

This comment has been minimized.

Copy link
Member

commented Sep 17, 2018

@dnikolayev I'll try to make a new release with CommonTestCase after work today

@lafrech

This comment has been minimized.

Copy link
Member

commented Sep 17, 2018

In order to keep this library small and easy to maintain, we've stopped adding support for new frameworks

Maybe we ought to update CONTRIBUTING.rst to mention that.

@dnikolayev

This comment has been minimized.

Copy link
Author

commented Sep 17, 2018

Thnx @sloria
I will wait.
While you're preparing the shared version of test class - I used a copy of it here: https://github.com/EndurantDevs/webargs-sanic
Will change to shared version once you create it. Probably it will be the great idea to have it shared between the core project and versions for other frameworks.

Thanks again for your help!

sloria added a commit that referenced this pull request Sep 17, 2018

sloria added a commit that referenced this pull request Sep 17, 2018

sloria added a commit that referenced this pull request Sep 17, 2018

sloria added a commit that referenced this pull request Sep 18, 2018

sloria added a commit that referenced this pull request Sep 18, 2018

sloria added a commit that referenced this pull request Sep 18, 2018

Various docs updates
* "Github" -> "GitHub"
* strict=True only applies to marshmallow 2
* Add note about framework integration in CONTRIBUTING

#287 (comment)
@sloria sloria referenced this pull request Sep 18, 2018

sloria added a commit that referenced this pull request Sep 18, 2018

Various docs updates
* "Github" -> "GitHub"
* strict=True only applies to marshmallow 2
* Add note about framework integration in CONTRIBUTING

#287 (comment)
@sloria

This comment has been minimized.

Copy link
Member

commented Sep 18, 2018

@dnikolayev OK, 4.1.0 includes webargs.testing.CommonTestCase.

@sloria

This comment has been minimized.

Copy link
Member

commented Sep 18, 2018

Also, I've updated CONTRIBUTING.rst. Good idea, @lafrech

@dnikolayev

This comment has been minimized.

Copy link
Author

commented Sep 18, 2018

I removed a copy of common tests. webargs.testing.CommonTestCase is used in tests.
Also, I've extended tests locally, including testing files validation via Sanic's test client.
Package is released, you can always send people who needs integration with Sanic to webargs-sanic

@sloria, Thanks for your help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.