Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Handling Arg(type, multiple=True, allow_missing=True) #30
core.get_value gets the _Missing type, places it into a list and then fails the type conversion/validation.
A terribly quick hack is in: venuatu@7824c96 but it doesn't take allow_missing into consideration.
@venuatu Thanks you for catching this and adding the failing test. I think the solution here is to allow
def get_value(d, name, multiple): val = d.get(name, Missing) if multiple and val is not Missing: #... return val
That way, the
Will need to think more about possible edge cases, but I think this is the desired solution since it is a minimal change doesn't affect the public interface.