Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix marshmallow 3.0.0rc1 compatibility #330

Merged
merged 2 commits into from Dec 2, 2018

Conversation

@lafrech
Copy link
Member

commented Nov 30, 2018

kwargs["data"] = error.data
if MARSHMALLOW_VERSION_INFO[0] < 3:
kwargs["fields"] = error.fields
kwargs["field_names"] = error.field_names

This comment has been minimized.

Copy link
@sloria

sloria Dec 2, 2018

Member

It might be worth checking if the version is <3.0.0rc1 so that 3.0.0 beta users' code won't be broken.

This comment has been minimized.

Copy link
@sloria

sloria Dec 2, 2018

Member

Latest commit does this.

Check against 3.0.0rc1
to maintain compatibility with 3.0 beta

@sloria sloria changed the title Fix marshmallow 3.0.0rc2 compatibility Fix marshmallow 3.0.0rc1 compatibility Dec 2, 2018

@sloria sloria merged commit 18e7ae0 into dev Dec 2, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@sloria sloria deleted the marshmallow_3.0.0rc1_compat branch Dec 2, 2018

@lafrech

This comment has been minimized.

Copy link
Member Author

commented Dec 2, 2018

Do we really need to maintain compatibility with all RC versions?

I thought once a pre-release version was out, all former pre-releases were considered obsolete.

@sloria

This comment has been minimized.

Copy link
Member

commented Dec 2, 2018

Eventually we can stop supporting all pre-release versions. But considering we only released 3.0.0rc1 a few days ago and many users are using 3.0 beta, I think we should support beta for this webargs release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.