Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add aiohttp path location #379

Merged
merged 1 commit into from Apr 9, 2019

Conversation

@zhenhua32
Copy link

commented Mar 22, 2019

alias to match_info

tzh
@sloria

This comment has been minimized.

Copy link
Member

commented Apr 7, 2019

I've no strong objection to this, but why do you think it's necessary? Thus far, we've tried to use the framework specific terminology for path params: "view args" in Flask, "matchdict" in Pyramid, "match info" in aiohttp.

@zhenhua32

This comment has been minimized.

Copy link
Author

commented Apr 8, 2019

compatible with OpenAPI , in OpenAPI match_info is normally called as path

@sloria

This comment has been minimized.

Copy link
Member

commented Apr 9, 2019

Fine by me. We'll probably want to make this consistent across all the parsers, but no reason to block merging. 🚢 🇮🇹

@sloria sloria merged commit 7dfd1e6 into marshmallow-code:dev Apr 9, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.