Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix marshmallow 3.0.0rc7 compatibility #395

Merged
merged 1 commit into from Jun 19, 2019

Conversation

@lafrech
Copy link
Member

commented Jun 18, 2019

Since 3.0.0rc7, decorated methods should accept kwargs.

Also, since 3.0.0b19, Field._deserialize should accept kwargs (marshmallow-code/marshmallow#1007). This was not done in webargs' custom fields, but no test was broken so we didn't see it.

This PR addresses all those issues.

@sloria

This comment has been minimized.

Copy link
Member

commented Jun 19, 2019

Ah good catch. Thanks

@sloria sloria merged commit bf26ca7 into dev Jun 19, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@lafrech lafrech deleted the fix_marshmallow_3.0.0rc7_compatibility branch Jun 19, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.