New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Live reload keybinding settings #189

Closed
rben01 opened this Issue Nov 12, 2017 · 5 comments

Comments

Projects
None yet
2 participants
@rben01

rben01 commented Nov 12, 2017

Would be nice if Marta reloaded the settings file whenever it was edited. Currently, you must restart Marta for changes to take effect.

@yanex yanex added the bug label Nov 12, 2017

@yanex

This comment has been minimized.

Contributor

yanex commented Nov 12, 2017

Marta supports hot reloading for settings from the first release.
Does the hot reloading not work for you at all, or the problem is with some particular settings?

@yanex yanex added this to the 0.4.5 milestone Nov 12, 2017

@rben01

This comment has been minimized.

rben01 commented Nov 12, 2017

Seems to not work for me at all. At least, with all settings I've edited.

@yanex

This comment has been minimized.

Contributor

yanex commented Dec 2, 2017

Unfortunately, I can't reproduce this issue.

Can you provide some more details about what Marta/macOS versions do you use?
Also, have you installed Marta to Applications folder?

@yanex yanex removed this from the 0.4.5 milestone Dec 2, 2017

@rben01

This comment has been minimized.

rben01 commented Dec 2, 2017

Sorry, looks like most settings do live reload. Just not the ones involving keybindings.

@yanex

This comment has been minimized.

Contributor

yanex commented Dec 3, 2017

Yes, key binding reloading is not supported yet.

@yanex yanex changed the title from Live reload settings to Live reload keybinding settings Dec 3, 2017

@yanex yanex added this to the 0.4.6 milestone Dec 3, 2017

@yanex yanex added the fixed label Dec 17, 2017

@yanex yanex closed this Dec 17, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment