New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quick Select: Highlight matched items #191

Closed
ronaldsuwandi opened this Issue Nov 15, 2017 · 3 comments

Comments

2 participants
@ronaldsuwandi

ronaldsuwandi commented Nov 15, 2017

At times I typed something in Marta and I didn't know I'm in the middle of quickSelect feature until I hit escape button. I think good reference to use is how Nimble Commander does it

screenshot 2017-11-15 09 20 17

Note that the typed text is at the top and there is underline in the filtered result

screenshot 2017-11-15 09 20 24

In Marta the typed text is all the way at the bottom - making it easy to miss

Another recommendation is perhaps turn on filterMatchedItems: true by default

@yanex yanex changed the title from More obvious interface when filtering using QuickSelect to Quick Select: Match highlighted items Nov 15, 2017

@yanex

This comment has been minimized.

Contributor

yanex commented Nov 15, 2017

I personally don't like filterMatchedItems, the blinking file list view is a bit irritating. This feature was implemented as a user request.
I also don't think that moving the filter text to the top will change anything. I think it's just a matter of habit. And there is no free space on the top anyway.

But the matching result highlighting really needs to be implemented.

@yanex yanex added the feature label Nov 15, 2017

@ronaldsuwandi

This comment has been minimized.

ronaldsuwandi commented Nov 15, 2017

True, blinking can be annoying. Actually now that I think about it, essentially this boils down to result highlighting. Once it's implemented, it won't be a problem anymore :-)

@ronaldsuwandi

This comment has been minimized.

ronaldsuwandi commented Nov 15, 2017

I also don't think that moving the filter text to the top will change anything. I think it's just a matter of habit. And there is no free space on the top anyway.

Not saying that Marta must copy NC behaviour but I noticed that in NC it swaps the path with the currently searched item which I found pretty neat and make it more obvious that it's on filtering mode

@yanex yanex changed the title from Quick Select: Match highlighted items to Quick Select: Highlight matched items Mar 26, 2018

@yanex yanex added this to the 0.5.1 milestone Mar 26, 2018

@yanex yanex added the fixed label May 27, 2018

@yanex yanex closed this May 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment