New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quick Select: Do not reset selection #216

Closed
ghost opened this Issue Dec 22, 2017 · 6 comments

Comments

2 participants
@ghost

ghost commented Dec 22, 2017

workflow:
select some PDF that contain a certain string and open them

how I tried:
search for the string, all PDFs show up cause I set "filterMatchedItems": true

(a small nit in "filterMatchedItems": true + "activateOnAnyCharacter": false
I hit / to start searching and then \ to perform a substring search but when I press \ the search list is empty and is only populated when I start typing)

I would now like to shift select some of those but as soon as I do, the MatchedItems List disappears

I'd suggest to keep it until esc is pressed

@yanex

This comment has been minimized.

Contributor

yanex commented Dec 27, 2017

So looks like there are two issues here.
The first one is that \ only acts as a filter while it should be completely ignored (no items should be filtered out) until at least one substring symbol is provided. The same is for /.
The second one is that Quick Select resets the selection.

@yanex yanex added this to the 0.4.7 milestone Dec 27, 2017

@yanex yanex added the bug label Dec 27, 2017

@ghost

This comment has been minimized.

ghost commented Dec 27, 2017

So looks like there are two issues here.

yes that is accurate

@yanex

This comment has been minimized.

Contributor

yanex commented Jan 5, 2018

(See also "Quick Select: Do not filter out elements on "/" or "" query #218").

@yanex yanex changed the title from search AND select is not possible to Quick Select: Do not reset selection Jan 5, 2018

@yanex yanex modified the milestones: 0.4.7, 0.5.1 Jan 5, 2018

@warpkanal

This comment has been minimized.

warpkanal commented Jan 7, 2018

Even more worse, this selection resetting is also affecting drag&drop operations: recently in a huge directory: I typed some characters to filter for the file I was looking for, then I wanted to drag it to another application, however a different file was dragged to the other application!
Why? Because on pressing the mouse button (to start dragging), selection is reset and you actually drag suddenly the item that would appear in that place if you had hit Esc before.
This makes filtering somewhat dangerous...

@warpkanal

This comment has been minimized.

warpkanal commented Mar 10, 2018

This bug is really driving me nuts: quick filter drag, mistake happened:
dd_broken

@yanex

This comment has been minimized.

Contributor

yanex commented Mar 15, 2018

@warpkanal Yes, this is a major bug indeed. I will fix it in the scope of 0.5.1 (hopefully, will be released quite soon after 0.5).

@yanex yanex added the fixed label May 26, 2018

@yanex yanex closed this May 26, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment