New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix delay between consequent "Toggle hidden files" executions #306

Closed
ghost opened this Issue Mar 30, 2018 · 6 comments

Comments

1 participant
@ghost
Copy link

ghost commented Mar 30, 2018

ctrl+h reveals/ shows hidden files immediately but the help text at the bottom has a very noticeable delay

this is minor and picky but maybe easy to fix

@yanex

This comment has been minimized.

Copy link
Contributor

yanex commented Mar 30, 2018

@monouser7dig Hm, I can't reproduce this.
The text you see ("Hidden files are not shown anymore") is just a notification message. Notifications are shown in a queue, so in case if you already have some notification shown, the next one will be shown with a delay.

@ghost

This comment has been minimized.

Copy link
Author

ghost commented Mar 30, 2018

show.mov.zip

this is realtime video, no background tasks

@ghost

This comment has been minimized.

Copy link
Author

ghost commented Mar 30, 2018

I think I see your point though, the "hidden files are now shown" takes some time and thus the "hidden files are not shown anymore" can't be shown directly.

Okay.

@yanex

This comment has been minimized.

Copy link
Contributor

yanex commented Mar 30, 2018

@monouser7dig Well, a notification message is a task. So when you press Cmd+H a number of times, Marta submits an equal number of "notification tasks" to the queue.
The problem is that notifications will the same type should probably override ones that was submitted earlier. I will think about this, thanks!

@yanex yanex added the feature label Mar 30, 2018

@ghost

This comment has been minimized.

Copy link
Author

ghost commented Mar 30, 2018

Yes ok it's not as easy as I first thought. Just read your blog post and I’m the most active user of Marta, and, to be honest, I’m very picky. motivated me to write this down.

But Don’t hesitate to thank software developers for their products. It’s really heartwarming! Marta is still feeling great 👍
(and 0.5 already is in homebrew, even with correct deletion instructions)

@yanex

This comment has been minimized.

Copy link
Contributor

yanex commented Mar 30, 2018

@monouser7dig I agree this behavior is straight-forward in theory, but in practice it turns out to be misleading. Will be fixed for sure.
Thanks for adding to cask! Actually, the update url have changed, it's https://updates.marta.yanex.org/release/ since 0.5. I can update it later, just caught a cold and need some sleep now 😃 .

@yanex yanex added this to the 0.6.1 milestone Jan 17, 2019

@yanex yanex changed the title ctrl+h - show hidden files delay Fix delay between consequent "Toggle hidden files" executions Jan 17, 2019

@yanex yanex added the fixed label Jan 17, 2019

@yanex yanex closed this Jan 17, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment