-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create an easy to use installer for RETC #6
Comments
FYI, I forked, this in to a git, and added a pull request as well |
Hey, thanks for your effort i appreciate it! Kind regards |
Great, thanks. I had sent this to you in an email as well. But I figured I'll put this here as well, just to be clear on what the install does now, and what might be needed: What it does:
Things to do:
Requirements/Use:
|
Issues found:
A possible fix would be validating the path and disabling the section checkbox within nsis (same for the uninstaller), this would also provide better user feedback if Overwatch is not installed.
Also im not too sure if we should add support for games using the sections at all a small gui tool would be beneficial in the future but for now lets fix the issue with the section and keep it like that. General remarks:Licensing:
I checked on the corsair cue license agreement a bit and found a section related to "export"
Although this seems more like physical copies it could apply to online distribution too. I would say we just redistribute them for now until i find more informations about that matter. Texts
Additional stuff (nice to have but not critical for this merge)
BuildScript
Once we have the english version fleshed out we can start accepting translations as pull requests |
Working on some of these now. |
Just added a commit to fix several of these things:
|
Thanks great job. Edit: Im preparing a simple python script. I checked on the corsair cue license agreement a bit details above. |
Another thing i just noticed that the deletion of RZSDK dlls from the windows/system32 folder breaks the razer passthrough support. |
I took a look at some options for the RzChomaSDK thing. The DLL files have detail info when right clicking them. The ProductName detail can be used to ID the DLL from Razer, and then skip it if the DLL belongs to Razer. There are a couple of NSIS plugins for reading this data. I'll modify the installer to check for this in the case that the DLL is found in system, and only offer to delete if it's not the Razer version. Additionally, I think we should add text to tell the user that if they DID have the SDK installed already, they should likely re-install afterwards, as the incorrect DLL was put in the System folder. Alternatively, this feature is one that is intended to help resolve a user error situation, and if it is more likely to cause problems, as opposed to solve problems, we could remove the feature, all together, and leave this issue as one users need to seek help for only in the case that they have made the mistake. Thoughts? |
If we could detect and warn the user reliably that would be great. Im thinking about adding a similar method to the server so it rejects loading the "wrong" dlls. |
Committed some changes.
IMPORTANT |
Also added a link to github on the uninstall entry in Add/Remove programs.
|
Hey thanks for that update, i changed the above status post to better reflect whats still missing: I would like the following options to be set, what do you think about that ? |
Hi! @t3nk3y , I try your installer but i have a issue with it, it work fine but when you leave overwatch(or any game) my keyboard still black and is not possible to get any lightning effect if the retc service is on. But if i launch the exe only without any service on i can get lightning effect when leaving overwatch. |
Jaazzy, do you know if the installer asked to, and DID remove the RazerChroma DLL from your system directory? |
Saying nothing because i don't have any Razer DLL in my system directory. |
Can you check Task Manager and see if Overwatch is still running, or if it shutdown? |
Overwatch is shutdown, when i relaunch it the keyboard still black no razer effect. Retc service is on. |
Try restarting the service from windows services, see if it that fixes it(for the moment) Can you paste the content of your server.log file as well? It will be in the folder you installed RETC to, usually C:\Program Files\RETC |
When restart service with windows services, every lightning effect come back my personnal effect and razer effect when launch overwatch. Content of server.log: |
Oh and when leaving overwatch , the processus still runing but this time i don't know why but my personnal lightning effect is here when leaving overwatch. |
MartB, I'm actually having this same issue. Well similar, my keyboard doesn't go black, but Overwatch gets stuck running in the background, and until I kill retc server, OW doesn't close, and things don't go back to normal until I RETC is closed(Whether run from NSSM or natively). I don't see how this would be related to the installer, any thoughts? Should this be moved to another issues? [2017-06-10 20:37:06.717] [error] [LightingSDK::init] CorsairCueSDK failed to load. RETC Release version: 3.1.1 |
@t3nk3y It's only happened when you use RETC as a service. When launching Retc-server-64.exe i don't have any problem(overwatch process is end and personnal keyboard lightning come back). |
@Jaazzy for me, it happens whether I run it manually or via the service. |
@t3nk3y For the dll loading as a service maybe we need to set a working directory ? Important: |
@t3nk3y The one from the last release. |
@MartB that seems to have been the issue. I had the installer placing those DLL's in the same folder. I've pushed some fixes:
|
LoL, 30 seconds after I pushed the fix. |
@Jaazzy can you verify its working for you with the latest builds ? How to get the latest code:
Just build the installer like you did before. (Dont forget to recompile all the projects) |
For DisplayVersion I could use a define, like you mentioned, or I could make the installer read the version information from the RETC exe file. Right now RETC doesn't have a version defined though. Do you think we should go that route, or should I use the compile time define? I've made the changes to the URL links and added EstimatedSize, which is calculated based on the install options selected. One other thing that we might want to add for Add/Remove; "Publisher", it's one of the columns displayed in the Add/Remove screen, and it looks a little bare without it. Not sure what you would want to put there though. |
I went ahead and added version number support. I also added some code that is commented out right now. It will get the version number from the EXE. However, since the EXE doesn't have a version number right now, NSIS will fail to compile the script(and there is no error checking I can do with the native functions to prevent this). Can uncomment if version number is added to the EXE. |
Just set the publisher to RETC Project |
Okay, committed changes for publisher, and enabled version checking. I don't have visual studio installed right now, so I can't compile the solution to test the version detection. I'm installing VS now, but if you test it, let me know if it isn't working. |
@MartB Nevermind , if i close overwatch with task manager and relaunch it effect is missing. Server.log: Using RETC_installer. |
Are you sure thats the latest build :o ? Also: SDKManager already initialized. indicates that you need to move the RzSDK dlls to a wrapper folder. Can you try the executables from above (Latest build with fileinfos) |
I creating the installer with Latest build with fileinfos For Rzsdk i cannot remove Rzdll from server directory because exe using it. |
Yeah thats the problem stop the service and move em Edit: wrong button hehe. |
Thanks! |
MakeNSIS is 2.3.3 If you want to try the OEM option, then update the nsExec lines like so: Adding the /OEM doesn't cause any issues on my system. |
Actually, since it doesnt cause issues for me with /OEM on there, I'm going to go ahead and push the /OEM version |
Yeah german edition + 3. nsis. Edit:
|
No problem. If it's working now, let me know if you want me to set it back to automatically go to the finish page. Also, FYI, I am running NSIS 3.01, but the version number on makensis is 2.3.3 |
I'm using the same version of NSIS. Want me to just turn off the logging for those commands? |
@MartB Everything work great if i delete Rzdll from the server directory thanks you. |
Shall I re-enable automatically going to the finish page, then? |
yup! |
Done |
@MartB glad to help. Thank you very much for taking the time to write and maintain RETC. |
You are welcome if you have ideas to make this project better just drop me issues :) |
@MartB No problem , Contact me if u need any help for testing with future version of RETC. |
In order to make use of RETC more foolproof and accessible, an easy to use installer would help.
I've built an NSIS based installer that also uses NSSM to set RETC up as a Windows system service.
I'm attaching an initial version of the NSI file. It expects the files to be in a specific path structure:
./files
./files/RETC_Installer.nsi
./files/win32
./files/win32/CUESDK_2015.dll
./files/win32/RzChromaSDK.dll
./files/win32/nssm.exe
./files/win32/retc-rpc-server-32.exe
./files/win64
./files/win64/CUESDK.x64_2015.dll
./files/win64/RzChromaSDK64.dll
./files/win64/nssm.exe
./files/win64/retc-rpc-server-64.exe
RETC_Installer.zip
The text was updated successfully, but these errors were encountered: