New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hidden fee removed #1

Merged
merged 3 commits into from Nov 14, 2017

Conversation

Projects
None yet
@gagarin55

gagarin55 commented Nov 13, 2017

All pools based on this open source software are mining hidden fee. This PR removes unnecessary recipients. Correct me if I'm wrong.

@martin-key

This comment has been minimized.

Show comment
Hide comment
@martin-key

martin-key Nov 13, 2017

Owner
Owner

martin-key commented Nov 13, 2017

@oliverw

This comment has been minimized.

Show comment
Hide comment
@oliverw

oliverw Nov 13, 2017

@StarbuckBG You're so full of shit it's not even funny anymore.

oliverw commented Nov 13, 2017

@StarbuckBG You're so full of shit it's not even funny anymore.

@martin-key

This comment has been minimized.

Show comment
Hide comment
@martin-key

martin-key Nov 13, 2017

Owner
Owner

martin-key commented Nov 13, 2017

@ZhiKosta

This comment has been minimized.

Show comment
Hide comment
@ZhiKosta

ZhiKosta Nov 13, 2017

Seriously dude, you don't even have to explain yourself. The code is there, anyone who has some brain can remove it easily and be done with it. Anyone who lack the skills of doing so, contributing a small fee for your time coding and giving it to him.
There will be always someone who shits on you. For job done, or not.

ZhiKosta commented Nov 13, 2017

Seriously dude, you don't even have to explain yourself. The code is there, anyone who has some brain can remove it easily and be done with it. Anyone who lack the skills of doing so, contributing a small fee for your time coding and giving it to him.
There will be always someone who shits on you. For job done, or not.

@oliverw

This comment has been minimized.

Show comment
Hide comment
@oliverw

oliverw Nov 13, 2017

@StarbuckBG No need to patronize me. Feel free to check out my repos. You're not as good as you might think.

oliverw commented Nov 13, 2017

@StarbuckBG No need to patronize me. Feel free to check out my repos. You're not as good as you might think.

@martin-key

This comment has been minimized.

Show comment
Hide comment
@martin-key

martin-key Nov 13, 2017

Owner
Owner

martin-key commented Nov 13, 2017

@buzztiaan

This comment has been minimized.

Show comment
Hide comment
@buzztiaan

buzztiaan Nov 13, 2017

its not a percentage, its half a coin

oh you're right, its just ~0.06 BTG per block, not the worst, about 15 usd, sorry, carry on

but might wanna make it optional (and on by default) ;)

buzztiaan commented Nov 13, 2017

its not a percentage, its half a coin

oh you're right, its just ~0.06 BTG per block, not the worst, about 15 usd, sorry, carry on

but might wanna make it optional (and on by default) ;)

@Gaspa79

This comment has been minimized.

Show comment
Hide comment
@Gaspa79

Gaspa79 Nov 13, 2017

@StarbuckBG

it is hard to create!!!

Are you serious? Hard to create? You just forked a coin that's all....

Gaspa79 commented Nov 13, 2017

@StarbuckBG

it is hard to create!!!

Are you serious? Hard to create? You just forked a coin that's all....

@martin-key

This comment has been minimized.

Show comment
Hide comment
@martin-key

martin-key Nov 13, 2017

Owner
Owner

martin-key commented Nov 13, 2017

@ZhiKosta

This comment has been minimized.

Show comment
Hide comment
@ZhiKosta

ZhiKosta Nov 13, 2017

ZhiKosta commented Nov 13, 2017

@evadogstar

This comment has been minimized.

Show comment
Hide comment
@evadogstar

evadogstar Nov 13, 2017

@StarbuckBG Really "I could just keep it for myself with pool.gold and make pool.gold be the only miner for Bitcoin Gold, but I have given this source." ??? It's you job to provide open source software to popularize, disseminate and through that make the coin more popular. You really don't understand that? If there will be only one pool, then all will say "good bye". I initially pricked up that you want to earn 1% at the official pool from start. And now even more.

You tried not to populate the coin, but get speed money. :( Unfortunately, my trust decreased.
From the beginning of the start, I thought that there would be a good coin.

About 0.5 it will be ok, if you will warn all about that from the start. Now, it's fine that you do that. But close the issue and apologize for community and keep going without such issues.

evadogstar commented Nov 13, 2017

@StarbuckBG Really "I could just keep it for myself with pool.gold and make pool.gold be the only miner for Bitcoin Gold, but I have given this source." ??? It's you job to provide open source software to popularize, disseminate and through that make the coin more popular. You really don't understand that? If there will be only one pool, then all will say "good bye". I initially pricked up that you want to earn 1% at the official pool from start. And now even more.

You tried not to populate the coin, but get speed money. :( Unfortunately, my trust decreased.
From the beginning of the start, I thought that there would be a good coin.

About 0.5 it will be ok, if you will warn all about that from the start. Now, it's fine that you do that. But close the issue and apologize for community and keep going without such issues.

@aayanl

This comment has been minimized.

Show comment
Hide comment
@aayanl

aayanl Nov 14, 2017

it's open source y'all, remove those four lines and bam, no fee

aayanl commented Nov 14, 2017

it's open source y'all, remove those four lines and bam, no fee

@aayanl

This comment has been minimized.

Show comment
Hide comment
@aayanl

aayanl Nov 14, 2017

(also its not that hard to rip commits from zcash into the bitcoin codebase as @StarbuckBG is making it out to be)

aayanl commented Nov 14, 2017

(also its not that hard to rip commits from zcash into the bitcoin codebase as @StarbuckBG is making it out to be)

@ACregan

This comment has been minimized.

Show comment
Hide comment
@ACregan

ACregan Nov 14, 2017

There are people commenting on a pull request saying 'why dont you change the code yourself? - its open source!'. This is an explainer for you:
Thats what a pull request is, People are literally offering to change this code for free so that this guy doesnt just cream a percentage of every transaction. He's refusing to allow that change. He is basically conning you all out of money and refusing to stop now people are calling him out on it. BCASH is rotten.

ACregan commented Nov 14, 2017

There are people commenting on a pull request saying 'why dont you change the code yourself? - its open source!'. This is an explainer for you:
Thats what a pull request is, People are literally offering to change this code for free so that this guy doesnt just cream a percentage of every transaction. He's refusing to allow that change. He is basically conning you all out of money and refusing to stop now people are calling him out on it. BCASH is rotten.

@buzztiaan

This comment has been minimized.

Show comment
Hide comment
@buzztiaan

buzztiaan Nov 14, 2017

totally agree on bcash yeah

and i sorta agreed with @ACregan , complaining is not the answer.

https://github.com/buzztiaan/node-stratum-pool/

that's my fork of this repo, with the devfee removed, nothing else changed

buzztiaan commented Nov 14, 2017

totally agree on bcash yeah

and i sorta agreed with @ACregan , complaining is not the answer.

https://github.com/buzztiaan/node-stratum-pool/

that's my fork of this repo, with the devfee removed, nothing else changed

@evadogstar

This comment has been minimized.

Show comment
Hide comment
@evadogstar

evadogstar Nov 14, 2017

They say us "We want to make bitcoin decentralized again".
Now compare with the words from developer: "I could just keep it for myself with pool.gold and make pool.gold be the only miner for Bitcoin Gold, but I have given this source."

LOL, super decentralization and thoughts

Now, I'm doubt what to do... Support the project or not

evadogstar commented Nov 14, 2017

They say us "We want to make bitcoin decentralized again".
Now compare with the words from developer: "I could just keep it for myself with pool.gold and make pool.gold be the only miner for Bitcoin Gold, but I have given this source."

LOL, super decentralization and thoughts

Now, I'm doubt what to do... Support the project or not

@martin-key

This comment has been minimized.

Show comment
Hide comment
@martin-key

martin-key Nov 14, 2017

Owner
Owner

martin-key commented Nov 14, 2017

@TheComputerGenie

This comment has been minimized.

Show comment
Hide comment
@TheComputerGenie

TheComputerGenie Nov 14, 2017

I’m accepting the pull request and dropping all the improvements for this software (:

Dude, you changed 2 lines (for the header), did a small bit of tidying (and making it only work for bgold), and that was "work" for you? Can you really look yourself in the mirror and call yourself a "developer" after doing that little and being that salty?

TheComputerGenie commented Nov 14, 2017

I’m accepting the pull request and dropping all the improvements for this software (:

Dude, you changed 2 lines (for the header), did a small bit of tidying (and making it only work for bgold), and that was "work" for you? Can you really look yourself in the mirror and call yourself a "developer" after doing that little and being that salty?

martin-key added some commits Nov 14, 2017

@martin-key martin-key merged commit 5d986d1 into martin-key:master Nov 14, 2017

@SpiryMedia

This comment has been minimized.

Show comment
Hide comment
@SpiryMedia

SpiryMedia Nov 15, 2017

Whoever doesn't like can easily remove and makes its own project. What is wrong with you people? Jesus. Can a man make 0.5%? Ugh so much greed.

SpiryMedia commented Nov 15, 2017

Whoever doesn't like can easily remove and makes its own project. What is wrong with you people? Jesus. Can a man make 0.5%? Ugh so much greed.

@LusienGG

This comment has been minimized.

Show comment
Hide comment
@LusienGG

LusienGG Nov 27, 2017

Nice one 👍

LusienGG commented on 12b669a Nov 27, 2017

Nice one 👍

This comment has been minimized.

Show comment
Hide comment
@chrixtal

chrixtal Nov 27, 2017

https://github.com/poolgold/ewbf-miner-btg-edition/releases

is this one?

They just ONLY put release note in source code zip!

so where can I find the real source code?

chrixtal replied Nov 27, 2017

https://github.com/poolgold/ewbf-miner-btg-edition/releases

is this one?

They just ONLY put release note in source code zip!

so where can I find the real source code?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment