Update for ruby-progressbar v1.0 #21

Merged
merged 5 commits into from Aug 4, 2012

2 participants

@jfelchner

Here are the necessary changes to get Fuubar working with the upcoming ruby-progressbar v1.0 release. I put out a gem as 1.0.0rc1 so you should be able to test it out and see if it will work for you.

I took a couple liberties with formatting to take advantage of the new features in v1.0 and you may not agree with them so adjust to taste. :)

The bar in this PR will output something like:

10/100 |====== 20 ======>                                         |  ETA: 10:10:10

Let me know if you have any questions.

@jfelchner

I also wanted to mention that I am going to keep strictly to SemVer with this gem, so you can safely put ~> 1.0 in your gemspec when we're ready for a final release.

@nashby
Collaborator

@jfelchner I like a new formatter! Could you rebase your branch against master? I can't merge it right now :(

@jfelchner

@nashby I rebased the branch and so I believe this pull request has been updated properly.

Let me stress, I did not test fuubar-cucumber after making these changes. I'm doing this simply to make your life a little easier. :) I would suggest having some people test it and send ruby-progressbar bugs to me. Once I'm fairly confident we're good to go, I'll release v1.0 final.

Hope you enjoy!

@nashby
Collaborator

@jfelchner I've just tested and it works. I think I'll release a new gem after ruby-progressbar's 1.0 release.

@nashby nashby merged commit 3b7a27e into martinciu:master Aug 4, 2012
@nashby
Collaborator

@jfelchner Thank you!

@jfelchner

Just a heads up, I went ahead and released ruby-progressbar 1.0.0 final.

@nashby
Collaborator

@jfelchner neat! I've just released 0.0.18 version with ruby-progressbar 1.0.0. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment