New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for pseudo-localisation #212

Merged
merged 6 commits into from Nov 17, 2018

Conversation

1 participant
@martincostello
Copy link
Owner

martincostello commented Aug 25, 2018

Add support for using Windows pseudo-localisation with the XLIFF format.

The pseudo-localised xlf for qps-Ploc was produced using PseudoLocalize.

@martincostello

This comment was marked as outdated.

Copy link
Owner

martincostello commented Sep 1, 2018

This will work correctly with the version of MSBuild that ships with .NET Core 2.2.0 and Visual Studio 15.9.

@codecov

This comment has been minimized.

Copy link

codecov bot commented Nov 10, 2018

Codecov Report

Merging #212 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #212   +/-   ##
=======================================
  Coverage   73.62%   73.62%           
=======================================
  Files         117      117           
  Lines        3742     3742           
  Branches      491      491           
=======================================
  Hits         2755     2755           
  Misses        746      746           
  Partials      241      241

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update abf1f66...48ff540. Read the comment docs.

@martincostello

This comment was marked as outdated.

Copy link
Owner

martincostello commented Nov 10, 2018

This will need rebasing onto #213.

@martincostello

This comment was marked as outdated.

Copy link
Owner

martincostello commented Nov 10, 2018

Also needs casing fixes, see martincostello/aspnet-core-pseudo-localization#6.

@martincostello martincostello force-pushed the Pseudo-Localisation branch from 1699142 to 361bea6 Nov 15, 2018

@martincostello martincostello changed the title [WIP] Add support for pseudo-localisation Add support for pseudo-localisation Nov 15, 2018

@martincostello martincostello removed the blocked label Nov 15, 2018

martincostello added some commits Nov 15, 2018

Add support for pseudo-localisation
Add support for using Windows pseudo-localisation using the XLIFF format.
Use PackageLicenseExpression
Use the new PackageLicenseExpression MSBuild property instead of PackageLicenseUrl.
Update ReportGenerator
Update ReportGenerator to the latest version.
Update packages
Update Microsoft.Azure.KeyVault.WebKey and Polly.
Run pseudo-localize when resources updated
Run the pseudo-localize .NET Core Global Tool when the XLF files are updated.
Fix pseudo-localized text
Fix broken tags by regenerating with PseudoLocalize 0.1.0-beta-1433.

@martincostello martincostello force-pushed the Pseudo-Localisation branch from 51d5712 to 48ff540 Nov 17, 2018

@martincostello martincostello merged commit 0d542e2 into master Nov 17, 2018

5 checks passed

codecov/patch Coverage not affected when comparing abf1f66...48ff540
Details
codecov/project 73.62% remains the same compared to abf1f66
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
security/snyk - src/LondonTravel.Site/package.json (martincostello (GitHub marketplace)) No manifest changes detected

@martincostello martincostello deleted the Pseudo-Localisation branch Nov 17, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment