Rewrite skill as .NET Core #124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add the skeleton solution files and edits to migrate the skill to .NET Core from node.js.
Split into module name and handler name (might be wrong). Add zip argument to deploy the publish output.
Remove trailing comma.
Add a new temporary function for testing deployment of the .NET Core version of the skill.
Fix the format of the handler name as it doesn't get constructed correctly (uses . instead of ::).
Update the IAM policy template to remove redundant role and add missing role.
Try and work around the default module name being wrong but the Travis CI tool not using the correct separator.
Use LogLine() instead of Log().
Update the basic response to set the version and response body.
Remove the node.js version of the skill to de-clutter ahead of the re-implementation.
Rename the function entry-point class.
Update class documentation.
Configure for .NET code rather than JavaScript.
Add skeleton implementation of the London Travel skill.
Update the assets for Visual Studio Code for .NET Core.
Implement the simple Cancel/Stop, Help, Launch and Stop handlers and add tests to ensure match existing output. Fix bugs in implementation found by those tests plus some general refactoring.
Remove unused local variable.
Setup dependency injection to prepare for implementing the intents that need to call the TfL API or skill API.
Add missing dependency injection registration for the JsonSerializerOptions class.
Add infrastructure to support intercepting HTTP requests to external services using bundle files.
Removed unused serialization code from SystemTextJsonContentSerializer.
Implement the intent for getting any disruption.
Increase the amount of memory allowed so that the DI container has enough memory to initialize.
Add a test for if getting disruption fails for some reason.
Implement the status intent. Refactor building SSML responses. Remove some redundant code branches. Change default HTTP timeout to 5 seconds. Log slot values in telemetry.
Use a class similar to HttpContextAccessor to flow the Lambda execution around to requests for access via dependency injection.
Use a resource file for most of the resource strings.
Add some more resource strings for the status intent.
Guard against invalid locale values when setting the culture.
Add the prescence of an access token (or not) to the telemetry properties.
Exclude unused method from code coverage.
Implement the correct response shape etc. for ISkillClient and add the parameter to set the access token.
Add support for returning a link account card.
Update the different bundles to not have conflicting Ids.
Implement the commute intent and add tests for main flows.
Log the locale of the current request.
Set CultureInfo.CurrentCulture instead of Thread.CurrentThread.CurrentCulture.
Nest the en-GB resx under Strings.resx.
Change the neutral resources language from en to en-US.
It isn't working on Linux and I don't know why, so just acquiesce and make the default UK English.
Add test cases for remaining uncovered code. Remove code that testing proved to be redundant.
Remove build and deploy for branch now that it's done.
martincostello
added
enhancement
dependencies
Codecov Report
@@ Coverage Diff @@
## master #124 +/- ##
==========================================
- Coverage 100% 98.68% -1.32%
==========================================
Files 16 24 +8
Lines 466 532 +66
Branches 91 0 -91
==========================================
+ Hits 466 525 +59
- Misses 0 7 +7
Continue to review full report at Codecov.
|
Some code refactoring to reduce the size of methods as recommended by Code Climate.
Remove node.js instructions.
|
Things to think about for the future:
|
Remove redundant exclusions.
Update Moq and ReportGenerator to their latest versions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR rewrites the node.js and JavaScript code for the skill Lambda into a .NET Core skill instead.