Skip to content

Compile for arm64 in GitHub Actions#975

Merged
martincostello merged 4 commits intomainfrom
cross-arch-aot
Nov 28, 2023
Merged

Compile for arm64 in GitHub Actions#975
martincostello merged 4 commits intomainfrom
cross-arch-aot

Conversation

@martincostello
Copy link
Owner

Cross-architecture compile for arm64 on GitHub Actions' ubuntu-latest hosted runner, which is x64.

See Cross-compilation.

Effectively a revert of #973.

Cross-architecture compile for arm64 on GitHub Actions' ubuntu-latest hosted runner.
See https://learn.microsoft.com/dotnet/core/deploying/native-aot/cross-compile#linux.
Effectively a revert of #973.
@martincostello martincostello added enhancement dependencies Pull requests that update a dependency file github_actions Pull requests that update GitHub Actions code labels Nov 28, 2023
I assumed that `sudo` wouldn't be needed on GitHub Actions, but I appear to be wrong.
@codecov
Copy link

codecov bot commented Nov 28, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4efd905) 96.72% compared to head (e2cf884) 96.72%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #975   +/-   ##
=======================================
  Coverage   96.72%   96.72%           
=======================================
  Files          45       45           
  Lines         641      641           
  Branches       71       71           
=======================================
  Hits          620      620           
  Misses          7        7           
  Partials       14       14           
Flag Coverage Δ
linux 95.94% <ø> (ø)
macos 96.72% <ø> (ø)
windows 96.72% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Forgot to remove in 36b378d.
Explicitly specify using bash as the shell where appropriate.
@martincostello
Copy link
Owner Author

/deploy dev

@github-actions
Copy link

github-actions bot commented Nov 28, 2023

🧪 Tests for deployment to dev passed ✅

@martincostello martincostello marked this pull request as ready for review November 28, 2023 17:25
@martincostello martincostello merged commit 07d1111 into main Nov 28, 2023
@martincostello martincostello deleted the cross-arch-aot branch November 28, 2023 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file enhancement github_actions Pull requests that update GitHub Actions code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant