New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to ASP.NET Core 2.1 #211

merged 14 commits into from May 31, 2018


2 participants
Copy link

martincostello commented Mar 28, 2018

  1. Update to ASP.NET Core 2.1.
  2. Update various npm dependencies.
  3. Use fixed version of npm and gulp.
  4. Use ReportGenerator for code coverage.
  5. Use Directory.Build.props and Directory.Build.targets.
  6. Use MSBuild to generate Git metadata.
  7. Remove Autofac.
  8. Run gulp publish when project opened.
Update to ASP.NET Core 2.1
Update to ASP.NET Core 2.1 (preview 1).
Update various npm dependencies.
Use fixed version of npm and gulp.
Use ReportGenerator for code coverage.
Use Directory.Build.props and Directpry.Build.targets.
Use MSBuild to generate Git metadata.
Remove Autofac.
Run gulp publish when project opened.

@martincostello martincostello added this to the future milestone Mar 28, 2018

@martincostello martincostello self-assigned this Mar 28, 2018


This comment has been minimized.

Copy link

codecov-io commented Mar 28, 2018

Codecov Report

Merging #211 into master will increase coverage by 4.44%.
The diff coverage is 89.91%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #211      +/-   ##
+ Coverage   56.48%   60.93%   +4.44%     
  Files          21       20       -1     
  Lines         809      750      -59     
  Branches      115      105      -10     
  Hits          457      457              
+ Misses        281      218      -63     
- Partials       71       75       +4
Impacted Files Coverage Δ
.../Website/Middleware/CustomHttpHeadersMiddleware.cs 77.77% <ø> (-0.61%) ⬇️
src/Website/Controllers/ToolsController.cs 66.66% <ø> (ø) ⬆️
src/Website/Program.cs 52.63% <75%> (+52.63%) ⬆️
...rc/Website/Extensions/ILoggingBuilderExtensions.cs 76.19% <76.19%> (ø)
src/Website/Startup.cs 90.19% <93.61%> (+90.19%) ⬆️
src/Website/Extensions/IConfigurationExtensions.cs 42.1% <0%> (+21.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f2ed6df...def1b9f. Read the comment docs.

martincostello added some commits Apr 11, 2018

Update to .NET Core 2.1 Preview 2
Update to preview 2 of .NET Core 2.1.
This appears to have broken a lot of the integration tests...
Run tests in Development
Run the integration tests as Development.
Fix broken test cause by redirection being enabled.
Update to .NET Core 2.1 RC1
Update to RC1 of the .NET Core 2.1 SDK.
Also update NodaTime to 2.2.6.
Remove CORS
Remove CORS as it isn't working and is no longer used.
Use final ASP.NET Core 2.1 release
Use the early access NuGet feed to migrate to the RTM version of ASP.NET Core 2.1.
Use npm 6.1.0
Update to npm 6.1.0.
Simplify Startup class
Simplify the Startup and Program classes and remove the need for the TestStartup class.
Remove StartupBase
Remove StartupBase and just have a Startup class.
Remove in-process IIS hosting
Remove configuration for IIS in-process hosting as this is no longer part of ASP.NET Core 2.1.0.
Remove early-access download NuGet feed
Remove the early-access download feed URL for 2.1.0 now that the packages have been published to
Use tag to download obtain script
Revert to using tags to get the script to download the SDK.
Fix incorrect variable being used
Fix incorrect variable name being used for the version tag in the download URL.

This comment has been minimized.

Copy link

martincostello commented May 30, 2018

Just waiting for Azure Web Apps to deploy the 2.1.0 runtime now.

@martincostello martincostello changed the title [DNMY] Update to ASP.NET Core 2.1 Update to ASP.NET Core 2.1 May 31, 2018

@martincostello martincostello removed the blocked label May 31, 2018

@martincostello martincostello merged commit 08e8658 into master May 31, 2018

4 checks passed

codecov/patch 89.91% of diff hit (target 56.48%)
codecov/project 60.93% (+4.44%) compared to f2ed6df
continuous-integration/appveyor/pr AppVeyor build succeeded
continuous-integration/travis-ci/pr The Travis CI build passed

@martincostello martincostello deleted the AspNetCore-2.1 branch May 31, 2018

martincostello added a commit that referenced this pull request Jul 29, 2018

Fix VS Code launch configuration
Fix the VS Code launch configuration since it was broken by #211.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment