New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Commas within data cannot be parsed properly #25

Closed
jdserato opened this Issue Dec 13, 2017 · 2 comments

Comments

Projects
None yet
2 participants
@jdserato

jdserato commented Dec 13, 2017

Instructions for filing an issue.

  1. Save your testcase (click on the Save link in CSVJSON menu bar) and copy/paste the URL here.
    http://www.csvjson.com/sql2json/fe1b434d7f320cebb4a984583b3b1599
  2. Describe your request.
    I have commas in my data (CSV) and upon exporting, all data after the comma is lost. Replacing the commas is a big rework and is unconventional.
@martindrapeau

This comment has been minimized.

Show comment
Hide comment
@martindrapeau

martindrapeau Dec 13, 2017

Owner

Thanks for reporting. I believe I have a solution for this. I hope to push it soon.

Owner

martindrapeau commented Dec 13, 2017

Thanks for reporting. I believe I have a solution for this. I hope to push it soon.

martindrapeau added a commit that referenced this issue Dec 14, 2017

@martindrapeau

This comment has been minimized.

Show comment
Hide comment
@martindrapeau

martindrapeau Dec 14, 2017

Owner

Give that a try and let me know if it works as you expect. The text is no longer cut. One thing I would have liked to keep are new line characters. Unfortunately, they are not allowed in JSON. I therefore removed them from the text. Alternatively, I could replace them with html <br> tags. Would that make sense?

Owner

martindrapeau commented Dec 14, 2017

Give that a try and let me know if it works as you expect. The text is no longer cut. One thing I would have liked to keep are new line characters. Unfortunately, they are not allowed in JSON. I therefore removed them from the text. Alternatively, I could replace them with html <br> tags. Would that make sense?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment