Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Error setting builddir to a nested path which doesn't yet exist #392

Closed
rgeary1 opened this Issue · 0 comments

2 participants

Richard Geary Evan Martin
Richard Geary

The following build.ninja code fails, as ninja doesn't do a recursive directory create for the builddir directory.
Caused by MakeDir in ninja.cc line 749.

repo:

build.ninja :
builddir = some/big/path

error message :
ninja : error: creating build directory some/big/path: No such file or directory
Richard Geary rgeary1 referenced this issue from a commit
Commit has since been removed from the repository and is no longer available.
Richard Geary rgeary1 referenced this issue from a commit in rgeary1/ninja
Richard Geary rgeary1 Fix for bug #392, ninja fails to recursively create the builddir
Change-Id: I1f98a4eb9c23ff5a215964b3bd89243d80cd0de1
6184a6b
Evan Martin martine referenced this issue from a commit
Evan Martin use DiskInterface to create the build directory
Fixes issue #392 (didn't handle creating nested build dirs right).

Moves MakeDir out of util.h; all code should go through
DiskInterface to simplify testing.  Moves ownership of the
DiskInterface into the client of the Builder, which also allows
removing some code that reached inside the object as well as
a minor leak.
cc222d3
Evan Martin martine closed this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.