Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

build metrics: StartEdge and EndEdge #446

Merged
merged 1 commit into from

3 participants

@maximuska

Total build time is also relevant.
The costs of StartEdge and EndEdge turned out to be quite surprising.
Especially if multiple targets are specified on edges.
(I've tried declaring depfiles targets explicitly)

Maxim Kalaev build metrics: StartEdge and EndEdge
Total build time is also relevant.
The costs of StartEdge and EndEdge turned out to be quite surprising.
Especially if multiple targets are specified on edges.
 (I've tried declaring depfiles targets explicitly)
c4fc36c
@buildhive

Evan Martin » ninja #199 SUCCESS
This pull request looks good
(what's this?)

@martine martine merged commit 2577a92 into martine:master
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Oct 12, 2012
  1. build metrics: StartEdge and EndEdge

    Maxim Kalaev authored
    Total build time is also relevant.
    The costs of StartEdge and EndEdge turned out to be quite surprising.
    Especially if multiple targets are specified on edges.
     (I've tried declaring depfiles targets explicitly)
This page is out of date. Refresh to see the latest.
Showing with 2 additions and 0 deletions.
  1. +2 −0  src/build.cc
View
2  src/build.cc
@@ -728,6 +728,7 @@ bool Builder::Build(string* err) {
}
bool Builder::StartEdge(Edge* edge, string* err) {
+ METRIC_RECORD("StartEdge");
if (edge->is_phony())
return true;
@@ -758,6 +759,7 @@ bool Builder::StartEdge(Edge* edge, string* err) {
}
void Builder::FinishEdge(Edge* edge, bool success, const string& output) {
+ METRIC_RECORD("FinishEdge");
TimeStamp restat_mtime = 0;
if (success) {
Something went wrong with that request. Please try again.