Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Remove "Warnings as errors" flags for windows. #505

Closed
wants to merge 1 commit into from

4 participants

@dlonie

The /WX flag causing the build on windows to fail when
compiling version.cc does not produce an object:

[1/3] CXX build\version.obj
FAILED: ninja.bootstrap.exe -t msvc -o build\version.obj -- cl /showIncludes /nologo /Zi /W4 /WX /wd4530 /wd4100 /wd4706 /wd4512 /wd4800 /wd4702 /wd4819 /wd4355 /GR- /wd4267 /DNOMINMAX /D_CRT_SECURE_NO_WARNINGS /DNINJA_PYTHON="python.exe" /Ox /DNDEBUG /GL -c src\version.cc /Fobuild\version.obj
src\version.cc(29) : error C2220: warning treated as error - no 'object' file generated

@dlonie dlonie Remove "Warnings as errors" flags for windows.
The /WX flag causing the build on windows to fail when
compiling version.cc does not produce an object:

[1/3] CXX build\version.obj
FAILED: ninja.bootstrap.exe -t msvc -o build\version.obj -- cl /showIncludes /nologo /Zi /W4 /WX /wd4530 /wd4100 /wd4706 /wd4512 /wd4800 /wd4702 /wd4819 /wd4355 /GR- /wd4267 /DNOMINMAX /D_CRT_SECURE_NO_WARNINGS /DNINJA_PYTHON="python.exe" /Ox /DNDEBUG /GL -c src\version.cc /Fobuild\version.obj
src\version.cc(29) : error C2220: warning treated as error - no 'object' file generated
7646a3f
@buildhive

Evan Martin » ninja #322 SUCCESS
This pull request looks good
(what's this?)

@tfarina

Why would we want that?

I think I fix for that is under review at #506

@dlonie

We'd want it so that ninja can bootstrap on windows.

Might be a better way to fix it, but this at least producing a working version of ninja.

@tfarina

But simply removing a flag is not the way to fix this. The warnings are good exactly for that, to catch bugs.

@dlonie

Absolutely -- this is just a triage fix that users can apply until a real fix is merged.

@martine
Owner

Looks like the other patch fixes things, hopefully. Thiago is right that I don't want to disable warnings.

@martine martine closed this
@dlonie dlonie deleted the branch
@dlonie

Just confirming that #506 does fix it for me. Thanks for the fast response! :+1:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Feb 20, 2013
  1. @dlonie

    Remove "Warnings as errors" flags for windows.

    dlonie authored
    The /WX flag causing the build on windows to fail when
    compiling version.cc does not produce an object:
    
    [1/3] CXX build\version.obj
    FAILED: ninja.bootstrap.exe -t msvc -o build\version.obj -- cl /showIncludes /nologo /Zi /W4 /WX /wd4530 /wd4100 /wd4706 /wd4512 /wd4800 /wd4702 /wd4819 /wd4355 /GR- /wd4267 /DNOMINMAX /D_CRT_SECURE_NO_WARNINGS /DNINJA_PYTHON="python.exe" /Ox /DNDEBUG /GL -c src\version.cc /Fobuild\version.obj
    src\version.cc(29) : error C2220: warning treated as error - no 'object' file generated
This page is out of date. Refresh to see the latest.
Showing with 0 additions and 1 deletion.
  1. +0 −1  configure.py
View
1  configure.py
@@ -120,7 +120,6 @@ def binary(name):
cflags = ['/nologo', # Don't print startup banner.
'/Zi', # Create pdb with debug info.
'/W4', # Highest warning level.
- '/WX', # Warnings as errors.
'/wd4530', '/wd4100', '/wd4706',
'/wd4512', '/wd4800', '/wd4702', '/wd4819',
# Disable warnings about passing "this" during initialization.
Something went wrong with that request. Please try again.