configure.py/bootstrap.py — account for CXXFLAGS. #676
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Take into account CXXFLAGS in the environment. I've tried to ensure this doesn't interfere with existing workflows which depend on using CFLAGS only by appending rather than replacing CFLAGS; this may lead to some extraneous duplicates, but it seems better than the alternative. Also, CXXFLAGS (and CFLAGS) are added to LDFLAGS with this change; this is to account for some special flags (like clang's -stdlib) which modify the behavior of both the compiler and the linker.
|
Evan Martin » ninja #636 SUCCESS |
|
Can this, or any other fix for the issue, be merged, please? |
|
Here is an updated/simplified version of this change which works for me with ninja 1.8.2 and which I have added to MacPorts: |
|
@ryandesign If you send me a pull request for the diff you linked to, I'll merge it. Closing this one out in the meantime since it doesn't apply anymore (and looked a bit more complex). |
This was referenced Apr 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Take into account CXXFLAGS in the environment in the bootstrap and configure scripts. I've tried to ensure this doesn't interfere with existing workflows which depend on using CFLAGS (only) by appending to, rather than replacing, CFLAGS; this may lead to some extraneous duplicates, but it seems better than the alternative.
Also, CXXFLAGS (and CFLAGS) are added to LDFLAGS with this change; this is to account for some special flags (like clang's
-stdlib) which modify the behavior of both the compiler and the linker.