New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LWRP Refactor #235

Merged
merged 22 commits into from Oct 2, 2014

Conversation

Projects
None yet
2 participants
@martinisoft
Owner

martinisoft commented Nov 6, 2013

Pulling this into a pull request now to re-gain some momentum on this branch and get it ready for a release. This will supersede a lot of the pull requests currently out there and should help resolve many of the issues going on currently with the cookbook. Much of the issues stem from the coupling to the rvm gem so this re-factor helps de-couple the rvm gem dependency and create an LWRP around setup and installation.

On the to-do list:

Cookbook Specs:

  • Resolve Travis-CI build issues

Test-Kitchen Integration Suite:

  • stock-system-and-user-ubuntu-1404
  • stock-system-and-user-ubuntu-1204
  • stock-system-and-user-ubuntu-1004
  • stock-system-and-user-ubuntu-1004
  • stock-system-and-user-debian-76
  • stock-system-and-user-centos-64
  • rubies-ubuntu-1404
  • rubies-ubuntu-1204
  • rubies-ubuntu-1004
  • rubies-ubuntu-1004
  • rubies-debian-76
  • rubies-centos-64
  • rbx-ubuntu-1404
  • rbx-ubuntu-1204
  • rbx-ubuntu-1004
  • rbx-debian-76
  • rbx-centos-64
  • installs-ubuntu-1404
  • installs-ubuntu-1204
  • installs-ubuntu-1004
  • installs-debian-76
  • installs-centos-64

fnichol and others added some commits Sep 7, 2013

Refactor RVM installation code into rvm_installation resource.
This is a nontrivial update and not 100% backwards compatible.
Update default ruby attribute
This is now set to 'ruby' which will always be the latest version and
patch release of ruby according to the current version of RVM being
installed. Overall, this is a more sensible future-proof default than
constantly updating patch levels in the default attributes.

@martinisoft martinisoft referenced this pull request Dec 27, 2013

Open

add maintainers? #232

@martinisoft

This comment has been minimized.

Show comment
Hide comment
@martinisoft

martinisoft Dec 27, 2013

Owner

Currently blocked on this due to a weird sudoers bug with the Ubuntu base boxes. I have filed a bug for the Bento project here and will investigate hacking this for the time being with the sudo cookbook. The problem I hit was attempting to verify the user/system install cookbook and running the BATS tests to execute the commands as the wigglebottom user. You're not allowed to with the current sudo permissions on the 13.04 basebox.

Owner

martinisoft commented Dec 27, 2013

Currently blocked on this due to a weird sudoers bug with the Ubuntu base boxes. I have filed a bug for the Bento project here and will investigate hacking this for the time being with the sudo cookbook. The problem I hit was attempting to verify the user/system install cookbook and running the BATS tests to execute the commands as the wigglebottom user. You're not allowed to with the current sudo permissions on the 13.04 basebox.

martinisoft added some commits Dec 27, 2013

Add apt to the runlist on this suite
It will fail due to a missing apt mirror and it needs updating before
attempting to install a few packages.
Updating to the latest patch release of 1.9.3
1.8.7 is officially EOL so it will slowly be removed from the
integration suite.
Update bats tests
This will help better test the system and user based installs of rvm
because it will need sudo access in order to execute any of the rvm
commands as that user for the user installation.
@martinisoft

This comment has been minimized.

Show comment
Hide comment
@martinisoft

martinisoft Dec 27, 2013

Owner

Even with a temporary fix, the user installation LWRP isn't working correctly in the rvm::user_install cookbook.

Owner

martinisoft commented Dec 27, 2013

Even with a temporary fix, the user installation LWRP isn't working correctly in the rvm::user_install cookbook.

@martinisoft

This comment has been minimized.

Show comment
Hide comment
@martinisoft

martinisoft Dec 29, 2013

Owner

Updated the PR with a checklist of the Test Suites that need to pass. Will need to also gather a breaking-change note set for the 1.0 release after this hits master.

Owner

martinisoft commented Dec 29, 2013

Updated the PR with a checklist of the Test Suites that need to pass. Will need to also gather a breaking-change note set for the 1.0 release after this hits master.

@martinisoft martinisoft added this to the Release 1.0 milestone Sep 2, 2014

@martinisoft martinisoft changed the title from A nontrivial refactor to LWRP Refactor Sep 2, 2014

martinisoft added a commit that referenced this pull request Oct 2, 2014

@martinisoft martinisoft merged commit 3950f22 into master Oct 2, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details

@martinisoft martinisoft deleted the a-nontrivial-refactor branch Oct 2, 2014

cmluciano added a commit to cmluciano/chef-rvm that referenced this pull request Mar 11, 2015

Redefine user-home and user-user.
This commit utilizes the newer methods of defining home and user in
accordance with
[PR235](martinisoft#235)

@cmluciano cmluciano referenced this pull request Mar 11, 2015

Merged

Cml/updaterubyblock #325

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment