From 10ef0e20416a3e6a818d5d9ac4a864989d9662a5 Mon Sep 17 00:00:00 2001 From: mehboodian Date: Mon, 22 Mar 2021 13:35:05 +0430 Subject: [PATCH 1/2] bug: fix body-maker filters ordering --- src/prompts/body-maker.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/prompts/body-maker.ts b/src/prompts/body-maker.ts index 5bbf526..7653666 100644 --- a/src/prompts/body-maker.ts +++ b/src/prompts/body-maker.ts @@ -26,8 +26,8 @@ export function filterFactory(rules: Rules) { return (value: string) => pipeWith( value, - v => leadingBlankFilter(v, rules['body-leading-blank']), v => maxLineLengthFilter(v, rules['body-max-line-length']), + v => leadingBlankFilter(v, rules['body-leading-blank']), v => v.replace(/\\n/g, '\n') ); } From 0545208f1de49a63ed9fb2a9dd4368f2a3b17591 Mon Sep 17 00:00:00 2001 From: mehboodian Date: Mon, 22 Mar 2021 13:58:25 +0430 Subject: [PATCH 2/2] test: add body leading empty newline test --- src/prompts/body-maker.test.ts | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/src/prompts/body-maker.test.ts b/src/prompts/body-maker.test.ts index 367b289..034c8fc 100644 --- a/src/prompts/body-maker.test.ts +++ b/src/prompts/body-maker.test.ts @@ -29,6 +29,18 @@ describe('body-maker', () => { expect(result).toBe(expected); }); + + it('should prepend body with and leading empty line', () => { + const rules: Rules = { + 'body-leading-blank': [Level.Error, 'always', undefined], + 'body-max-line-length': [Level.Error, 'never', Infinity] + }; + const userTypedBody = 'my message should be prepended with an empty new line'; + + const result = filterFactory(rules)(userTypedBody); + + expect(result).toBe('\nmy message should be prepended with an empty new line'); + }); }); describe('transformerFactory', () => {