Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update winnow to 0.6+ and vecmap-rs to 0.2+ #324

Merged
merged 3 commits into from
Apr 8, 2024

Conversation

gruebel
Copy link
Contributor

@gruebel gruebel commented Apr 7, 2024

  • removed the bugfix suffix of the dependencies for hcl-edit to reduce dependabots update frequency. let me know, if you are ok with it. I can also do the same for the other crates or change it back 🙂
  • fixed some clippy warnings, nothing troublesome

by the way, great project 💪 saved me for doing some regex juggling 😄

@martinohmann
Copy link
Owner

martinohmann commented Apr 8, 2024

Hey @gruebel, thanks for your efforts to migrate to winnow 0.6!

CI is failing for nightly. This is not caused by your change and is already broken in main. I'm going to fix that and will let you know once this is done so you can rebase the PR.

@martinohmann
Copy link
Owner

@gruebel rebasing onto the latest main should get rid of the nightly build failure now.

@martinohmann martinohmann merged commit 9b5a4a3 into martinohmann:main Apr 8, 2024
5 checks passed
@github-actions github-actions bot mentioned this pull request Apr 8, 2024
@gruebel gruebel deleted the update-winnow branch April 8, 2024 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants