New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove explicit references to @glimmer/syntax on transforms #196

Merged
merged 1 commit into from Dec 28, 2017

Conversation

Projects
None yet
2 participants
@cibernox
Collaborator

cibernox commented Dec 26, 2017

It may or may not be enough to fix #185

@cibernox

This comment has been minimized.

Show comment
Hide comment
@cibernox

cibernox Dec 26, 2017

Collaborator

@buschtoens ESLint doesn't like the syntax of the new component. How did CI pass on your PR?

Collaborator

cibernox commented Dec 26, 2017

@buschtoens ESLint doesn't like the syntax of the new component. How did CI pass on your PR?

@buschtoens

This comment has been minimized.

Show comment
Hide comment
@buschtoens

buschtoens Dec 26, 2017

Collaborator

... m.. magic? 🔮😅

I'll try to check it out later. Currently on vacation. 🏂

Collaborator

buschtoens commented Dec 26, 2017

... m.. magic? 🔮😅

I'll try to check it out later. Currently on vacation. 🏂

@buschtoens buschtoens referenced this pull request Dec 28, 2017

Merged

Upgrade all the things #197

@buschtoens

This comment has been minimized.

Show comment
Hide comment
@buschtoens

buschtoens Dec 28, 2017

Collaborator

I wasn't able to reproduce it locally, but maybe this is because ember-try did not useYarn? 🤷‍♂️

Anyway #197 runs just fine.

Collaborator

buschtoens commented Dec 28, 2017

I wasn't able to reproduce it locally, but maybe this is because ember-try did not useYarn? 🤷‍♂️

Anyway #197 runs just fine.

@buschtoens

This comment has been minimized.

Show comment
Hide comment
@buschtoens

buschtoens Dec 28, 2017

Collaborator

Did you close this PR intentionally or did GitHub do it? I don't think #197 closes #185. 🤔

Collaborator

buschtoens commented Dec 28, 2017

Did you close this PR intentionally or did GitHub do it? I don't think #197 closes #185. 🤔

@cibernox

This comment has been minimized.

Show comment
Hide comment
@cibernox

cibernox Dec 28, 2017

Collaborator

I did not close it. I think the keword "fix #196" triggered this.

Collaborator

cibernox commented Dec 28, 2017

I did not close it. I think the keword "fix #196" triggered this.

@cibernox cibernox reopened this Dec 28, 2017

@cibernox

This comment has been minimized.

Show comment
Hide comment
@cibernox

cibernox Dec 28, 2017

Collaborator

It's green now. No idea why.

Collaborator

cibernox commented Dec 28, 2017

It's green now. No idea why.

@cibernox cibernox merged commit 118c8e3 into master Dec 28, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@cibernox cibernox deleted the remove-explicit-references-to-@glimmer/syntax branch Dec 28, 2017

@buschtoens

This comment has been minimized.

Show comment
Hide comment
@buschtoens

buschtoens Dec 28, 2017

Collaborator

I did not close it. I think the keword "fix #196" triggered this.

Interesting, I just linked the comment and the keyword was not dotted underlined, as it usually is. Seems like we discovered another GitHub bug. 😛

It's green now. No idea why.

Me neither ¯_(ツ)_/¯

Collaborator

buschtoens commented Dec 28, 2017

I did not close it. I think the keword "fix #196" triggered this.

Interesting, I just linked the comment and the keyword was not dotted underlined, as it usually is. Seems like we discovered another GitHub bug. 😛

It's green now. No idea why.

Me neither ¯_(ツ)_/¯

@buschtoens

This comment has been minimized.

Show comment
Hide comment
@buschtoens

buschtoens Dec 28, 2017

Collaborator

Want me to merge and push out an rc.2?

Collaborator

buschtoens commented Dec 28, 2017

Want me to merge and push out an rc.2?

@cibernox

This comment has been minimized.

Show comment
Hide comment
@cibernox

cibernox Dec 28, 2017

Collaborator

That would be great, although I suspect I'll have to make another update to ember-ast-helpers to fix this.

Collaborator

cibernox commented Dec 28, 2017

That would be great, although I suspect I'll have to make another update to ember-ast-helpers to fix this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment