Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for role qualifications #15

Open
crsh opened this issue Jul 1, 2020 · 5 comments
Open

Add support for role qualifications #15

crsh opened this issue Jul 1, 2020 · 5 comments
Labels
enhancement New feature or request

Comments

@crsh
Copy link
Collaborator

crsh commented Jul 1, 2020

I'll summarize our discussion below.

We may want to qualify our roles. Given that this seems important to us, maybe we should implement support for this feature before releasing the app? In terms of how we could implement this in the sheet, I suggest we could turn the tick boxes into a drop-down list to select from (e.g., Lead, Equal, Supporting, None; I just tried this out, it works nicely). This would obviate some of the input validation.

We can also say that if someone does not want to use the more nuanced version they can just set every contributor "equal", as the default choice should be "none" in all cells.

But we should provide help to users about how to decide who is the lead and who is supporting etc.

There are some open questions for the human readable report:

Does this mean that for the reporting of the credit taxonomy we would have the role, then the lead contributor, then the equal contributors, then the supporting? If there are ore contributors saying equal or supporting then they will be organized by the order in publication? What do you think? Should I write the lead and supporting roles in parenthesis after the name?

@crsh crsh added the enhancement New feature or request label Jul 1, 2020
@crsh crsh added this to the First release milestone Jul 1, 2020
@marton-balazs-kovacs
Copy link
Owner

marton-balazs-kovacs commented Jul 1, 2020

Hi Frederik,

I will change the code according to your last review and then I will start to work on this. Do you think that the way I proposed the change for the human readable report make sense? Because I will code then accordingly.

I think we should add this option before the first release.

@crsh
Copy link
Collaborator Author

crsh commented Jul 1, 2020

I'll give my thoughts one by one.

Does this mean that for the reporting of the credit taxonomy we would have the role, then the lead contributor, then the equal contributors, then the supporting?

Yes, that was my thinking.

If there are ore contributors saying equal or supporting then they will be organized by the order in publication?

That would probably be the easiest way to implement this and it would also make sense, I think.

Should I write the lead and supporting roles in parenthesis after the name?

Either that or we could add superscripts, which may be a little more concise?

@marton-balazs-kovacs
Copy link
Owner

Hi,

I agree with your third point. It is a good idea to add superscripts.

@crsh crsh removed this from the First release milestone Jul 8, 2020
@jcolomb
Copy link
Collaborator

jcolomb commented Jul 13, 2020

I would not include this in the first release:

  1. there is no jats version of that information, I would tend to wait and make some more research about how to include that, are there any example in the literature?
  2. I fear it could induce some bad behaviour and fight between the authors, and the time might not be good for that and we need to have people used to credit, before asking them to do more

If you want to go for it anyway, the default value should be "unspecified" and not "equal" in order to avoid unnecessary conflicts.

@crsh
Copy link
Collaborator Author

crsh commented Jul 13, 2020

Hi Julien, thanks for your comments. I agree with what you are suggesting. It is pretty much what we landed on in another private e-mail discussion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants