Convert from QtConnectivity to Bluez 5 DBus API #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Provides a wrapper around the Bluez 5 DBus API to replace the QtConnectivity Qt Bluetooth classes needed for the app. There are still some missing features and TODOs. Most notably, the scan currently doesn't filter on BLE devices, and error reporting needs improvement.
|
Hi @llewelld As I mentioned on the forum: Is the dropping of the QtConnectivity is carved into stone? Bluez5 compatible QtConnectivity looks to be existing since ages. What is the reason of not going that direction? Legal issues? Backporting efforts? |
I've replied there on the forum to avoid splitting the discussion across two places. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provides a wrapper around the Bluez 5 DBus API to replace the QtConnectivity Qt Bluetooth classes needed for the app.
There are still some missing features and TODOs. Most notably, the scan currently doesn't filter on BLE devices, and error reporting needs improvement.
I've also unfortunately only had a chance to do minimal testing, it definitely needs more.
To help with making clear what's going on, I've included links to the relevant Bluez 5 docs, and to the equivalent
dbus-sendanddbus-monitorcalls that would be used at the command line to achieve the same results (I find these to be very useful for testing).As an explanation for this PR, your app covers a good cross-section of Bluetooth functionality (especially BLE) so it seemed like a good example for testing out the process of switching from QtConnectivity to Bluez 5. I was hoping this might be useful to others considering making the switch too. I apologise for its rather raw state.