Skip to content

Don't blow up on 'No such nick/channel' and showErrors before blowing up! #107

Closed
wants to merge 2 commits into from

3 participants

@cjstewart88
  • Don't blow up on err_nosuchnick, catch it and log it.
  • It's a little easier to debug when we throw the pretty errors before blowing up.
@jakswa
jakswa commented Sep 14, 2012

👍 I'd like to see this as well, or at least some variation of it.

@qsheets
qsheets commented Oct 5, 2012

cjstewart88: all this extra code is unnecessary. The culprit is a single line self.emit('error', message);. This is what is making the client "blow up", as you say. All I did was change that line to self.emit('ircError', message);, and voila! It doesn't throw any more exceptions from IRC error responses.

@cjstewart88

We ended up noticing that a well, forgot to update this PR.

@cjstewart88 cjstewart88 closed this Oct 5, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.