Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

Fixed the message object being modified on MODE command. #111

Merged
merged 2 commits into from

3 participants

@Pumpuli

Array.splice modifies the array so subsequent raw-listeners would get
the modified array. Use Array.slice instead. (Maybe this was a typo...?)

@Pumpuli Pumpuli Fixed message being modified on MODE command
Array.splice modifies the array so subsequent raw-listeners would get
the modified array. (Maybe this was a typo...?)
25d237f
@damianb

please check your line endings.

@Pumpuli Pumpuli Fixed the line endings back to \n
Didn't pay attention to line endings in the last commit...
cfe12f0
@martynsmith martynsmith merged commit 85bff00 into martynsmith:master
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Oct 20, 2012
  1. @Pumpuli

    Fixed message being modified on MODE command

    Pumpuli authored
    Array.splice modifies the array so subsequent raw-listeners would get
    the modified array. (Maybe this was a typo...?)
Commits on Oct 24, 2012
  1. @Pumpuli

    Fixed the line endings back to \n

    Pumpuli authored
    Didn't pay attention to line endings in the last commit...
This page is out of date. Refresh to see the latest.
Showing with 1 addition and 1 deletion.
  1. +1 −1  lib/irc.js
View
2  lib/irc.js
@@ -139,7 +139,7 @@ function Client(server, nick, opt) {
if ( !channel ) break;
var modeList = message.args[1].split('');
var adding = true;
- var modeArgs = message.args.splice(2);
+ var modeArgs = message.args.slice(2);
modeList.forEach(function(mode) {
if ( mode == '+' ) { adding = true; return; }
if ( mode == '-' ) { adding = false; return; }
Something went wrong with that request. Please try again.