Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Fixed the message splitting on Client.say #112

Merged
merged 1 commit into from

2 participants

Jaakko Puntila Martyn Smith
Jaakko Puntila

Client.send expects the parameters to be strings but here messagePart is returned by RegExp.exec which returns the match object.

Martyn Smith martynsmith merged commit ddf0507 into from
Martyn Smith
Owner

Thanks for spotting and fixing that so quickly :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Oct 25, 2012
  1. Jaakko Puntila
This page is out of date. Refresh to see the latest.
Showing with 2 additions and 2 deletions.
  1. +2 −2 lib/irc.js
4 lib/irc.js
View
@@ -684,8 +684,8 @@ Client.prototype.say = function(target, text) { // {{{
}).forEach(function(line) {
var r = new RegExp(".{1," + self.opt.messageSplit + "}", "g");
while ((messagePart = r.exec(line)) != null) {
- self.send('PRIVMSG', target, messagePart);
- self.emit('selfMessage', target, messagePart);
+ self.send('PRIVMSG', target, messagePart[0]);
+ self.emit('selfMessage', target, messagePart[0]);
}
});
}
Something went wrong with that request. Please try again.