Skip to content

encoding support with documentation #113

Closed
wants to merge 2 commits into from

4 participants

@noraesae

Hi!

I rebased and documented the pull request #85.
Please check the patch and documentation,
and if there's something wrong or i can do further, please let me know.

Thanks!

Regards.

@martynsmith
Owner

This looks great. Just a quick thought, do you think it'd be better to decode the buffer after all the chunks have been received (then you could get rid of that comment about potential bugs on multi-byte characters spanning chunks).

It seems like it'd be fairly easy to do.

Either way, If I don't hear back from you I'll merge this :-)

@noraesae

Thank you for the reply.
I'll hack into it.

Regards.

@noraesae

I commited a patch to decode the buffer after all the chunks've been received.

Plz check the patch, and if there's something wrong, let me know.

Thanks!

Regards.

rlidwka and others added some commits Apr 18, 2012
@rlidwka rlidwka encoding support
Rebased and documented by @noraesae
555ec66
HyeonJe Jun Process decoding after all the chunks have been received.
Prevent bugs that can occur when decode the large chunk with
multibyte encoding.
639432c
@noraesae

ping

This was referenced Jan 20, 2013
@sigkell sigkell closed this May 29, 2014
@tarlepp tarlepp referenced this pull request Jan 5, 2015
Closed

Added message auto encoding #269

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.