Fixed issue with colons invoking unsought events and added user message support for PART #118

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
2 participants
Contributor

quentinxs commented Nov 3, 2012

For issue with colons, please refer back to issue #98.

Colons are now implemented on a case-by-case basis so they don't invo…
…ke unsought events and added user message support for PART
Owner

martynsmith commented Nov 3, 2012

The send functionality change seems like a regression, if anything you should just change the behaviour from only adding a colon if the message includes a space to always including a colon (and not changing every call to it).

The message for part support both lacks documentation, and the function signature hasn't been updated (so it clearly won't work).

Ideally these two patches should be separate pull requests, and regardless, the issues above need fixing.

@martynsmith martynsmith closed this Nov 3, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment