Fixed Client.join callback for multiple channels #121

Closed
wants to merge 2 commits into
from

Conversation

Projects
None yet
3 participants

Fixed Client.join to be able to correctly handle the callbacks when joining multiple channels

You cannot do this as this is how channel passwords are handled. Client.join('#mychannel mypassword', function() {}) would normally result in the client joining #mychannel with mypassword but with this change it attempts to join the non existent channel mypassword. Maybe you should consider letting .join take either an array or the standard string?

Owner

martynsmith commented Jan 20, 2013

Yes, I agree with @n0valyfe. Any reason you can't just call .join() multiple times?

Ha I forgot about this pull request

I ended up just joining channels individually anyway as martyn suggested above.

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment