Added SASL support #125

Merged
merged 4 commits into from Sep 6, 2013

Conversation

Projects
None yet
4 participants
@gsf
Contributor

gsf commented Dec 27, 2012

Set sasl: true in options, along with nick, userName, and password,
for SASL login (required for some IP ranges for connecting to
Freenode, etc.).

No docs or tests, sorry. Happy to provide if you give some guidance.

Gabriel Farrell added some commits Dec 27, 2012

Gabriel Farrell
Added SASL support
Set sasl: true in options, along with nick, userName, and password,
for SASL login (required for some IP ranges for connecting to
Freenode, etc.).
@quentinxs

This comment has been minimized.

Show comment
Hide comment
@quentinxs

quentinxs Dec 28, 2012

Contributor

While I applaud your effort, you may want to rework your code a bit as CAP is/ can be used for more than SASL. Other than that, documentation is as easy as updating docs/API.rst to reflect your changes to the library.

Contributor

quentinxs commented Dec 28, 2012

While I applaud your effort, you may want to rework your code a bit as CAP is/ can be used for more than SASL. Other than that, documentation is as easy as updating docs/API.rst to reflect your changes to the library.

@gsf

This comment has been minimized.

Show comment
Hide comment
@gsf

gsf Dec 28, 2012

Contributor

Yes, I was kind of greedy with the CAP signals since nothing else in the library is using them yet. The third commit makes it more specific. When a use case comes up for other CAP functionality it can be accommodated then.

The last commit adds the option to the docs.

If these additions don't hinder other uses, I would really appreciate their inclusion. I can't connect to Freenode via my phone without them (anything on the T-Mobile network is subject to SASL).

Contributor

gsf commented Dec 28, 2012

Yes, I was kind of greedy with the CAP signals since nothing else in the library is using them yet. The third commit makes it more specific. When a use case comes up for other CAP functionality it can be accommodated then.

The last commit adds the option to the docs.

If these additions don't hinder other uses, I would really appreciate their inclusion. I can't connect to Freenode via my phone without them (anything on the T-Mobile network is subject to SASL).

@gsf

This comment has been minimized.

Show comment
Hide comment
@gsf

gsf Dec 28, 2012

Contributor

I could also move those listeners into the if ( self.opt.sasl ) block so that they only exist when SASL is enabled.

Contributor

gsf commented Dec 28, 2012

I could also move those listeners into the if ( self.opt.sasl ) block so that they only exist when SASL is enabled.

@kamaln7

This comment has been minimized.

Show comment
Hide comment

kamaln7 commented Aug 8, 2013

👍

martynsmith added a commit that referenced this pull request Sep 6, 2013

@martynsmith martynsmith merged commit bafa696 into martynsmith:master Sep 6, 2013

@martynsmith

This comment has been minimized.

Show comment
Hide comment
@martynsmith

martynsmith Sep 6, 2013

Owner

This looks fine, I notice that we get fairly wildly varying coding styles, I think I might get some jshint config set up and try to get everyone to conform to that :-)

Owner

martynsmith commented Sep 6, 2013

This looks fine, I notice that we get fairly wildly varying coding styles, I think I might get some jshint config set up and try to get everyone to conform to that :-)

@gsf

This comment has been minimized.

Show comment
Hide comment
@gsf

gsf Sep 14, 2013

Contributor

Thanks for merging this in!

Contributor

gsf commented Sep 14, 2013

Thanks for merging this in!

@gsf gsf deleted the gsf:sasl branch Sep 14, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment