Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Fixed bug with coilon inside message string #133

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
3 participants

If you write e.g. "this is a message with : a colon in it" the resulting string is ":this" because it parses the last colon found, not the first.

Contributor

qsheets commented Jan 11, 2013

Already fixed (though not committed), please see the comments under #128.

qsheets added a commit to qsheets/node-irc that referenced this pull request Jan 19, 2013

Fix for receiving messages with colons
This fixes issues #122, #128 and #133.

Example lines include:
    :some.irc.net 324 webuser #channel +Cnj 5:10
    :nick!user@host QUIT :Ping timeout: 252 seconds
    :nick!user@host PRIVMSG #channel :so : colons: :are :: not a problem ::::
Owner

martynsmith commented Jan 20, 2013

I'm going to close this now (pull request #137 from @qsheets fixed this issue I believe).

If you still have issues, please pull master and look at the tests I've written, if you can extend the tests with your own failing examples, that will provide a much better basis for trying out new patches).

Thanks,

uiureo added a commit to uiureo/node-irc that referenced this pull request Feb 2, 2013

Fix for receiving messages with colons
This fixes issues #122, #128 and #133.

Example lines include:
    :some.irc.net 324 webuser #channel +Cnj 5:10
    :nick!user@host QUIT :Ping timeout: 252 seconds
    :nick!user@host PRIVMSG #channel :so : colons: :are :: not a problem ::::
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment