Ping timeout support #176

Closed
wants to merge 1 commit into from

4 participants

@philip-peterson

I've added support for ping timeouts, as requested in issue #76.

It may be worth reviewing the way I am triggering reconnects, since I've seen other pull requests use .disconnect(), although that doesn't seem right to me.

@atomizer

+1, had to implement this myself.

@waddlesplash

@martynsmith can this be merged? I'd like it too.

@Trinitas

this was my work around:

(serverside)
client.on('disconnect', function () {
Client.disconnect();
});

if the node server don't get a heartbeat from the socket.io client it disconnects the user from irc

@philip-peterson

Closed this one because it had some bad behavior.. opened a more correct PR here: #214

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment