Include channels user was in when 'kill' is emitted #72

Merged
merged 1 commit into from Jan 7, 2012

Conversation

Projects
None yet
2 participants
@alexwhitman
Contributor

alexwhitman commented Nov 22, 2011

Implements #69

Would prompt a version change as the signature of the emit is changed.

@martynsmith

This comment has been minimized.

Show comment Hide comment
@martynsmith

martynsmith Dec 19, 2011

Owner

Any reason you wouldn't just put the channels as the last argument in the method signature? I concur that it's not quite as nice, but it definitely wouldn't break backward compatibility.

Thoughts?

Owner

martynsmith commented Dec 19, 2011

Any reason you wouldn't just put the channels as the last argument in the method signature? I concur that it's not quite as nice, but it definitely wouldn't break backward compatibility.

Thoughts?

@alexwhitman

This comment has been minimized.

Show comment Hide comment
@alexwhitman

alexwhitman Dec 19, 2011

Contributor

I did it this way to keep the signatures consistent, with message always being the last. There's no reason why it couldn't be swapped around though.

Contributor

alexwhitman commented Dec 19, 2011

I did it this way to keep the signatures consistent, with message always being the last. There's no reason why it couldn't be swapped around though.

martynsmith added a commit that referenced this pull request Jan 7, 2012

Merge pull request #72 from whitman/emit-kill-channels
Include channels user was in when 'kill' is emitted

@martynsmith martynsmith merged commit 02593ba into martynsmith:master Jan 7, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment