PING event #82

Closed
wants to merge 1 commit into
from

Projects

None yet

4 participants

@guanix
guanix commented Apr 4, 2012

Client will emit a ping event when it receives a ping.

@martynsmith
Owner

Can you please add this to the documentation?

If you do, then I'll merge this :-)

@jaekwon
jaekwon commented Oct 24, 2012

there's nothing much to document... it's just background handling of connections, right?
i just got bitten by the lack of this.

@damianb
Contributor
damianb commented Oct 24, 2012

agreeing...why hasn't this been merged? it's been 6 months...this would be something rather useful and just leaving it dark out of stubbornness to get someone else to do something is pretty shameful.

@martynsmith
Owner

@damianb - That's all well and good, but I'm a busy person. Yes, it would be trivial for to add the documentation, and it would be trivial for anyone to add the documentation.

I will try get around to it, but I'm not really keen on merging code that doesn't keep the documentation up to date. That's the start of a slippery slope.

@martynsmith
Owner

@jaekwon If you read the diff you'll see that there is an event to document, and so far as I can tell nothing yet subscribes to it, so I fail to see how it can be causing any issues for anyone.

@martynsmith martynsmith added a commit that closed this pull request Oct 25, 2012
@martynsmith ping event (closes #82) ecec980
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment