Support + and ! channels #99

Closed
wants to merge 1 commit into
from
Jump to file or symbol
Failed to load files and symbols.
+1 −1
Diff settings

Always

Just for now

View
@@ -382,7 +382,7 @@ function Client(server, nick, opt) {
break;
}
self.emit('message', from, to, text, message);
- if ( to.match(/^[&#]/) ) {
+ if ( to.match(/^[&#+!]/) ) {

This comment has been minimized.

@damianb

damianb Aug 13, 2012

Contributor

have you tested this to confirm it works? those are regex metachars...

@damianb

damianb Aug 13, 2012

Contributor

have you tested this to confirm it works? those are regex metachars...

This comment has been minimized.

@villelahdenvuo

villelahdenvuo Aug 13, 2012

They do work in character sets, but of course escaping them might be good practice.

@villelahdenvuo

villelahdenvuo Aug 13, 2012

They do work in character sets, but of course escaping them might be good practice.

This comment has been minimized.

@damianb

damianb Aug 13, 2012

Contributor

yeah, that's what's been ground into me by my mentors for years, heh. wasn't aware that it wasn't necessary in sets, but I think I'll keep the habit for clarity's sake.

@damianb

damianb Aug 13, 2012

Contributor

yeah, that's what's been ground into me by my mentors for years, heh. wasn't aware that it wasn't necessary in sets, but I think I'll keep the habit for clarity's sake.

self.emit('message#', from, to, text, message);
self.emit('message' + to, from, text, message);
if ( to != to.toLowerCase() ) {