This repository was archived by the owner on Apr 28, 2020. It is now read-only.
Blocks workspace switches while multitasking view toggle animation is active #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
February 8, 2016 03:04
I assume it is fine to change the type from ActivatableComponent to DeepinMultitaskingView because from a semantic point of view workspace_view is always going to be some sort of "multitasking view". If abstraction is desired, I propose to create an interface for different types of "multitasking view" plugins, which contains is_toggling(). Alternatively it could be added to ActivatableComponent in terms of an abstract function. However, this would require WindowOverview to be updated as well which would currently be of no use.
Workspace switching is inactive as long as workspace_view is toggling. This makes sure that the animation does not look broken. Alternatively we could simply delay the call to switch_to_next_workspace instead of completely blocking it (using either Timeout or by binding a callback function to a "toggle finished" signal).
|
@fasheng Thanks for the patch, the fix's fine. Although I prefer quick responsiveness but blocking is absolutely ok at this situation. |
|
Thanks very much. But looks the github2gerrit plugin still not works. I will download the PR and push to gerrit manually(we host repos in github as mirrors for https://cr.deepin.io), and close here then. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3.
I have solved the problem described in #3 by simply blocking workspace switch commands as long as the multitasking view's toggle animation is running. As explained in the git comments, delaying the workspace switch instead of blocking it.
I personally prefer blocking, because I feel like a delay might feel "sluggish" to the user, but we could experiment. Maybe it's hardly recognizable.