Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong WINDOWID with tmux #66

Merged
merged 4 commits into from Nov 5, 2019

Conversation

@infokiller
Copy link
Contributor

infokiller commented Nov 4, 2019

No description provided.

@infokiller

This comment has been minimized.

Copy link
Contributor Author

infokiller commented Nov 4, 2019

I see this was resolved in #63 so closing

@infokiller infokiller closed this Nov 4, 2019
@infokiller

This comment has been minimized.

Copy link
Contributor Author

infokiller commented Nov 4, 2019

Oops, closed the wrong PR. Reopening.

@infokiller infokiller reopened this Nov 4, 2019
Copy link
Owner

marzocchi left a comment

thank @infokiller, I left a couple of comments. also github says there are conflicts, can you have a look?

notify.plugin.zsh Show resolved Hide resolved
notify.plugin.zsh Outdated Show resolved Hide resolved
Copy link
Contributor Author

infokiller left a comment

Thanks for the review, I applied the suggested changes. Github doesn't show me there's conflicts, can you please check now?

notify.plugin.zsh Show resolved Hide resolved
notify.plugin.zsh Outdated Show resolved Hide resolved
@marzocchi

This comment has been minimized.

Copy link
Owner

marzocchi commented Nov 5, 2019

never mind, it shows conflict only when I choose "Rebase and merge"

@marzocchi marzocchi merged commit 0dba043 into marzocchi:master Nov 5, 2019
@marzocchi

This comment has been minimized.

Copy link
Owner

marzocchi commented Nov 5, 2019

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.